Add support for Rails 8.0 #111
Merged
+33
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rkrage
commented
Nov 25, 2024
| @@ -10,13 +10,13 @@ jobs: | |||
| - 15 | |||
| - 16 | |||
| ruby: | |||
| - "3.1" | |||
There was a problem hiding this comment.
Same comment from here: jcoleman/relation_to_struct#23 (comment)
The other versions of Rails still support 3.1 but it was much easier to just remove it completely instead of special-casing Rails 8. I think this should be fine as Ruby 3.1 is EOL in 4 months?
- Remove Ruby 3.1 from build matrix
jcoleman
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
~>syntax in appraisal definitions such that we pull in the latest patch versions of Rails when the tests runWe'll want jcoleman/relation_to_struct#23 to be merged and released firstCloses #109