Allowing option values to be loaded from imported data #235
Conversation
|
For clarification, please see my comment here |
|
|
* Adding OptionsFromKeyEntry to GeneralGroup * added optionFromKey:boolean, optionsKey:string field properties to allow select and radio to load their options form imported data. * updated importer to import initialData for keys used by selects and radios * Also refactored playground submit data to properly filter to only fields that are present. Refs bpmn-io#197
dfulgham
force-pushed
the
Provide-values-for-multi-element-components-via-Form-data
branch
from
adcc245
to
faa0a75
Compare
|
Thanks for this PR. This looks solid and is from the first look a good implementation of #197. We have the overall story of "supporting dynamic forms" on our roadmap for Q2 and would like to consider this PR here as part of that excercise. So please understand that we really appreciate this groundwork, but cannot merge as of now. I will leave it open and keep it in the backlog. In the meantime: |
|
Hi @dfulgham, a small update from our side: We plan to work on this topic this quarter and I will likely use this pull request as a starting point! I will use the referenced issue to keep things up to date 👍 |
|
@pinussilvestrus thats great news, sorry been away for a bit moving geographically. I would like to work on this project a lot more, any chance of getting a little more integrated in this project? One of the items I want to get working on a little more is the custom components pieces, like the file upload and star rating components I created in one of my forks. |
|
@dfulgham Happy to work with you on form-js to improve it for the better. Making the toolkit pluggable and also whitelisting components is one thing we're not working on right now, but you did a tremendous amount of work. I#d love to help you to shape these things up and get them into our codebase (#239 (comment)). At the same time we're working on dynamic form values right now (#197), not dependent, but also exciting. Glad you also jumped in to share your feedback from the integrators perspective there! |
|
You can track what we're working on in form land via our task board, too. |
|
Closed in favor of #270, thank you for the contribution we inspired ourselves from this work. |
Implements and closes #197