Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom button example #10

Merged
merged 1 commit into from
Nov 28, 2023
Merged

feat: add custom button example #10

merged 1 commit into from
Nov 28, 2023

Conversation

pinussilvestrus
Copy link
Contributor

This adds an example of how to create a custom button component with a custom behavior on click. It also show cases how to add FEEL support for a property (message).

This uses not-yet-released hooks from form-js-viewer.

Kapture 2023-11-28 at 13 23 03

@pinussilvestrus pinussilvestrus requested a review from a team November 28, 2023 12:24
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 28, 2023
Copy link

@Skaiir Skaiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge or address the one thing. Thanks for this it'll help everybody :D

schema: schema,
data: {},
additionalModules: [
RenderExtension
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth prefixing Component Or CustomButton here, just for people to make the connection easier. I feel like when I see RenderExtension it's too generic and I glance over it a little, despite it being a critical part of the code.

Same for properties panel, but less important.

@fake-join fake-join bot merged commit 214d73c into master Nov 28, 2023
3 checks passed
@fake-join fake-join bot deleted the custom-button-example branch November 28, 2023 13:16
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 28, 2023
@Skaiir
Copy link

Skaiir commented Nov 28, 2023

Ah whoops right automerge :trollface:

@pinussilvestrus
Copy link
Contributor Author

Always progress 😄

Adressed the small naming issue via d83ad31 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants