Type hints #2153
Merged
Type hints #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpmn-io-tasks
bot
added
needs review
nikku
requested review from
a team,
philippfromme and
barmac
and removed request for
a team
nikku
force-pushed
the
type-hints
branch
2 times, most recently
from
6fdde53
to
707ad8a
Compare
This PR builds on upon diagram-js provided service and event typing: * bpmn-io/diagram-js#862 It allows you to specify (public) types exposed by your BPMN toolkit trough a ServiceMap. Events exposed are parsed from the EventBus dynamic types. Closes #2121
barmac
approved these changes
Apr 30, 2024
Absolutely. I wanted to ship the basic increment first to unlock future improvements. The blog is a good idea; maybe I manage to write it the next days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to type the contents of your bpmn-js powered editor:
TODO
Closes #2121