fixes #580 and makes it "fit" #1373
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes bottlepy#580 It seems the current release and the dev versions are different. This dev version adds a headers kwarg, which is not how the rest of bottle works, which uses `response.headers()`. This fixes bottlepy#580, which was already, somewhat fixed, but also changes it to not need a headers kwarg, just copy from the existing response headers. Either way, you can close bottlepy#580 now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #580
It seems the current release and the dev versions are different. This dev version adds a headers kwarg, which is not how the rest of bottle works, which uses
response.headers(). This fixes #580, which was already, somewhat fixed, but also changes it to not need a headers kwarg, just copy from the existing response headers.Either way, you can close #580 now.