Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Library model fields #623

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Conversation

williln
Copy link
Collaborator

@williln williln commented Aug 31, 2023

cc @frankwiles @4down

The fields being removed in this PR have never actually made it to the frontend at all and aren't used for anything, so I propose we remove them to clean up the codebase.

Copy link
Collaborator

@frankwiles frankwiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. This was from the G&M design.

Copy link
Contributor

@d-spencer-strickland d-spencer-strickland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, I don't think they're fields we would really care to have in the future either, so getting rid of them makes sense. Thanks!

@williln williln merged commit 00e68cf into develop Sep 1, 2023
4 checks passed
@williln williln deleted the remove-unused-library-fields branch September 1, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants