Import maintainers when there are no maintainers #618
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #616
The problem was that when
import_library_versions
runs and loads the maintainers, it only tries to load them if theLibraryVersion
was created. Since older versions of WinAPI had maintainers, and my local db had maintainers for the current version, it looks like the LibraryVersion for WinAPI-1.82.0 was probably created, but for whatever reasons its maintainers didn't load. And on subsequent runs of this import, the maintainers wouldn't be attempted since the LibraryVersion record already existed.I changed the logic to try and import maintainers if there aren't any, regardless of whether the LibraryVersion record is new.
Once this is merged,
./manage.py import_library_versions --min-release=1.82
will need to be run in deployed environments.