Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import maintainers when there are no maintainers #618

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

williln
Copy link
Collaborator

@williln williln commented Aug 29, 2023

closes #616

The problem was that when import_library_versions runs and loads the maintainers, it only tries to load them if the LibraryVersion was created. Since older versions of WinAPI had maintainers, and my local db had maintainers for the current version, it looks like the LibraryVersion for WinAPI-1.82.0 was probably created, but for whatever reasons its maintainers didn't load. And on subsequent runs of this import, the maintainers wouldn't be attempted since the LibraryVersion record already existed.

I changed the logic to try and import maintainers if there aren't any, regardless of whether the LibraryVersion record is new.

Once this is merged, ./manage.py import_library_versions --min-release=1.82 will need to be run in deployed environments.

Copy link
Collaborator

@frankwiles frankwiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@williln williln merged commit 44db4ac into develop Aug 30, 2023
4 checks passed
@williln williln deleted the 616-winapi-bug branch August 30, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Win.API maintainers not showing
2 participants