Avoid using boost::filesystem w/string conversions on Windows #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@klemens-morgenstern are you interested in merging this change? |
Converting from wstring to string (or vice versa) with boost::filesystem requires Filesystem to be compiled. However if these conversions are avoided, then boost::filesystem will not be needed by downstream projects.
achow101
force-pushed
the
avoid-path-wstring-convert
branch
from
42d30d1
to
6633016
Compare
|
Can this be closed after #264? |
klemens-morgenstern
force-pushed
the
develop
branch
from
8639dc2
to
611dac1
Compare
klemens-morgenstern
force-pushed
the
develop
branch
2 times, most recently
from
ac43b71
to
58586e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting from wstring to string (or vice versa) with boost::filesystem requires Filesystem to be compiled. However if these conversions are avoided, then boost::filesystem will not be needed by downstream projects.
A project I am working on is trying to remove boost filesystem and we noticed that doing so results in a linker error when cross compiling to windows. The root cause was identified to be that boost process for Windows ends up using some conversion functions which require boost filesystem to be compiled. This patch resolved those issues for us.