Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake and MSVC Compiler issues #170

Merged
merged 5 commits into from
Oct 1, 2024

Commits on Apr 26, 2024

  1. Fix MSVC Compiler issue.

    MSVC in cmake has always been a boolean variable ( see https://cmake.org/cmake/help/latest/variable/MSVC.html)
    detecting the MSVC Compiler requires therefore "if (MSVC)"
    
    further, the MSVC Compiler will always emit '199711L' for __cplusplus, if it is called without the option '/Zc:__cplusplus'
    
    this odd behavior will break any version check in the headers.
    e.g. './include/boost/parser/detail/text/detail/begin_end.hpp' or 'boost/hana/traits.hpp
    
    therefore "add_compile_options(/Zc:__cplusplus)" is always nrequired for the MSVC compiler
    MPo committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    35ca898 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. quotes were missing for string comparison; use alternative compiler f…

    …rontend check
    Martin Posch committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    af198b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. remove commented-out cmake

    Martin Posch committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    077cdba View commit details
    Browse the repository at this point in the history
  2. avoid usage of CMAKE_CXX_COMPILER_FRONTEND_VARIANT and go with pre 3.…

    …14 version
    Martin Posch committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    eab545e View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Revert "avoid usage of CMAKE_CXX_COMPILER_FRONTEND_VARIANT and go wit…

    …h pre 3.14 version"
    
    This reverts commit eab545e.
    Martin Posch committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    ebc346f View commit details
    Browse the repository at this point in the history