Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feat: 모든 날짜 조회수 통계 API 구현 #219

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

✨ feat: 모든 날짜 조회수 통계 API 구현 #219

wants to merge 6 commits into from
+210 −4

Conversation

Jo-Minseok
Copy link
Collaborator

@Jo-Minseok Jo-Minseok commented Nov 26, 2024 •
edited
Loading

🔨 테스크

Important

#214 PR에서 변경된 점이 있어서, 하나는 테스트 실패 뜨는데, 이 부분 이미 #214에서 고쳤습니다!

Issue

📋 작업 내용

  • /api/statistic/all 테스트 코드 작성
  • /api/statistic/all Notion API 명세서 작성
  • Swagger 일일 조회수 (/api/statistic/all) API 명세 응용
  • 전체 조회수 limit 개수에 맞게 게시글 제한
  • /api/statistic/all API 구현

📷 스크린 샷(선택 사항)

@Jo-Minseok Jo-Minseok added the ✨ Feature 기능 구현 label Nov 26, 2024
@Jo-Minseok Jo-Minseok self-assigned this Nov 26, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 26, 2024 •
edited
Loading

✅ Deploy Preview for denamu canceled.

Name Link
🔨 Latest commit 91de6a2
🔍 Latest deploy log https://app.netlify.com/sites/denamu/deploys/6746a393fb40bd00080862bd

CodeVac513
CodeVac513 reviewed Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@CodeVac513 CodeVac513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많으셨습니다!
저는 항상 민석님한테 많이 배워요. :)

관리자 권한에 대해 질문 남겨놨는데 그 부분을 수정하게 된다면 테스트 쪽도 수정이 필요할 것 같습니다.

server/test/statistic/all.e2e-spec.ts Show resolved Hide resolved
server/src/statistic/statistic.controller.ts Show resolved Hide resolved
asn6878
asn6878 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@asn6878 asn6878 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#214 PR에서 확인한 내용들 인지라, 최종안 생기면 그친구만 병합하거나, 아니면 따로 별도로 버전관리 후에 하나씩 병합해주셔도 좋을 것 같아요.
고생하셨습니다~ 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asn6878 asn6878 asn6878 approved these changes

@CodeVac513 CodeVac513 CodeVac513 approved these changes

Assignees

@Jo-Minseok Jo-Minseok

Labels
✨ Feature 기능 구현
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] 전체 조회수 통계 API 구현
3 participants
@Jo-Minseok @CodeVac513 @asn6878