⚡️ perf: login -\> auth 변경, redis 풀스캔 O(N) 개선

boostcampwm-2024 · Nov 27, 2024 · 9eb5df6 · 9eb5df6
1 parent 5649e67
commit 9eb5df6
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 8 deletions.
diff --git a/server/src/admin/admin.service.ts b/server/src/admin/admin.service.ts
@@ -41,31 +41,43 @@ export class AdminService {
     const sessionId = uuid.v4();
 
     if (cookie) {
-      this.redisService.redisClient.del(`login:${cookie}`);
+      this.redisService.redisClient.del(`auth:${cookie}`);
     }
 
     let cursor = '0';
+    let scanFlag = false;
     do {
       const [newCursor, keys] = await this.redisService.redisClient.scan(
         cursor,
         'MATCH',
-        'login:*',
+        'auth:*',
         'COUNT',
         100,
       );
 
       cursor = newCursor;
 
-      for (const key of keys) {
-        const sessionValue = await this.redisService.redisClient.get(key);
+      if (!keys.length) {
+        continue;
+      }
+
+      const values = await this.redisService.redisClient.mget(keys);
+
+      for (let i = 0; i < keys.length; i++) {
+        const sessionValue = values[i];
         if (sessionValue === loginId) {
-          await this.redisService.redisClient.del(key);
+          await this.redisService.redisClient.del(keys[i]);
+          scanFlag = true;
+          break;
         }
       }
+      if (scanFlag) {
+        break;
+      }
     } while (cursor !== '0');
 
     this.redisService.redisClient.set(
-      `login:${sessionId}`,
+      `auth:${sessionId}`,
       admin.loginId,
       `EX`,
       this.SESSION_TTL,

diff --git a/server/src/common/guard/auth.guard.ts b/server/src/common/guard/auth.guard.ts
@@ -14,7 +14,7 @@ export class CookieAuthGuard implements CanActivate {
   async canActivate(context: ExecutionContext): Promise<boolean> {
     const request = context.switchToHttp().getRequest<Request>();
     const sid = request.cookies['sessionId'];
-    const loginId = await this.redisService.redisClient.get(`login:${sid}`);
+    const loginId = await this.redisService.redisClient.get(`auth:${sid}`);
     if (!loginId) {
       throw new UnauthorizedException('인증되지 않은 요청입니다.');
     }

diff --git a/server/test/statistic/today.e2e-spec.ts b/server/test/statistic/today.e2e-spec.ts
@@ -25,7 +25,7 @@ describe('Today view count statistic E2E Test : GET /api/statistic/today', () =>
         email: '[email protected]',
         rssUrl: 'https://test.com/rss',
       }),
-      redisService.redisClient.set('login:test1234', 'test'),
+      redisService.redisClient.set('auth:test1234', 'test'),
       redisService.redisClient.zadd(
         redisKeys.FEED_TREND_KEY,
         '1',