Skip to content

Commit

Permalink
Remove python 3.7 from the CI tests, as Pillow 10 has dropped support…
Browse files Browse the repository at this point in the history
… for it. Added 3.11
  • Loading branch information
mel-mason committed Oct 10, 2023
1 parent 7477615 commit 2b34e54
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.7", "3.8", "3.9", "3.10"]
python-version: ["3.8", "3.9", "3.10", "3.11"]
steps:
- uses: actions/checkout@v3
- name: Set up Python ${{ matrix.python-version }}
Expand Down
4 changes: 2 additions & 2 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Installation

``pip install git+https://github.com/bodleian/image-processing.git``

- Tested on Python 3.8, but should work with most 3.x versions
- Mostly tested on Python 3.8, but should also work on newer 3.x versions

Dependencies
~~~~~~~~~~~~
Expand Down Expand Up @@ -92,7 +92,7 @@ To just use Kakadu directly through the wrapper:
Development and Testing
-----------------------

We run a subset of our unit tests on Python versions 3.7+ using Github Actions. Tests that require Kakadu are skipped, as we cannot access the proprietary Kakadu executables from a public repository. Any changes should be tested locally, with Kakadu installed, rather than relying on the CI testing alone. You can use requirements.txt to set up a Python virtual environment.
We run a subset of our unit tests on Python versions 3.8+ using Github Actions. Tests that require Kakadu are skipped, as we cannot access the proprietary Kakadu executables from a public repository. Any changes should be tested locally, with Kakadu installed, rather than relying on the CI testing alone. You can use requirements.txt to set up a Python virtual environment.

The tests compare directly against image files to check for regression. When updating dependencies like Pillow these test image files may sometimes no longer match, especially jpgs. The current set of test images were generated with Pillow 10.0.1, Exiftool 12.40, and Kakadu 8.2

Expand Down

0 comments on commit 2b34e54

Please sign in to comment.