Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstrings of best methods and radius value information in Cif #55

Merged
merged 6 commits into from
Oct 28, 2024

Conversation

bobleesj
Copy link
Owner

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description (Screenshots, files, etc)

docs for describing finding the best CN values and the polyhedron, for determining cif radius

Checklist

  • Are the tests passing?
  • If it's a new feature, have tests been written?
  • Have you added the .rst news file?

Added to documentation?

  • README.md
  • Official documentation
  • Google Codelab
  • No documentation needed

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.29%. Comparing base (e97f17a) to head (40891b9).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   97.29%   97.29%           
=======================================
  Files          35       35           
  Lines        1403     1403           
=======================================
  Hits         1365     1365           
  Misses         38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bobleesj bobleesj marked this pull request as ready for review October 28, 2024 12:13
@bobleesj bobleesj merged commit dbaf324 into main Oct 28, 2024
4 checks passed
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added PR template for all contributors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants