fix: format refund logs and update cosmos-sdk #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## bc-fusion #991 +/- ##
=============================================
- Coverage 48.82% 48.82% -0.01%
=============================================
Files 127 127
Lines 12800 12802 +2
=============================================
Hits 6250 6250
- Misses 6120 6122 +2
Partials 430 430 ☔ View full report in Codecov by Sentry. |
plugins/tokens/plugin.go
Outdated
| continue | ||
| } | ||
|
|
||
| logger.Info("succeed to refund swap", "swapId", swapID, "swap", fmt.Sprintf("%+v", swapItem)) | ||
| swapKeeper.SetLatestProcessedRefundSwapKey(ctx, swapIterator.Key()) |
There was a problem hiding this comment.
Can we record the key and update the lasted proceed key outside the loop?
There was a problem hiding this comment.
if outside the loop, you will never know the key. will this be heavy in Endblock?
There was a problem hiding this comment.
I've checked the codes, and found that swap would be gc in the breathe block, so I think this change is unnecessary
j75689
changed the title
forcodedancing
approved these changes
Jan 5, 2024
unclezoro
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
format refund logs and update cosmos-sdk
Rationale
n/a
Example
n/a
Changes
Notable changes:
Preflight checks
make build)make test)make integration_test)Already reviewed by
n/a
Related issues
n/a