cmd/utils, core/rawdb, triedb/pathdb: flip hash to path scheme #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fynnss
previously approved these changes
Feb 28, 2024
sysvm
force-pushed
the
fix-defaultpbss
branch
5 times, most recently
from
5b59c0c
to
362ce7c
Compare
sysvm
changed the title
sysvm
force-pushed
the
fix-defaultpbss
branch
2 times, most recently
from
443b140
to
f6b276d
Compare
* cmd/utils, core/rawdb, triedb/pathdb: flip hash to path scheme * graphql: run tests in hash mode as the chain maker needs it
sysvm
changed the title
sysvm
force-pushed
the
fix-defaultpbss
branch
2 times, most recently
from
4ab747f
to
fe59497
Compare
fynnss
reviewed
Mar 18, 2024
zzzckck
reviewed
Mar 18, 2024
zzzckck
previously approved these changes
Mar 18, 2024
sysvm
force-pushed
the
fix-defaultpbss
branch
7 times, most recently
from
c4a2a3f
to
26fc35f
Compare
buddh0
approved these changes
Mar 19, 2024
zzzckck
approved these changes
Mar 19, 2024
This was referenced Mar 21, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR flips the default state-scheme from hash to path, though it also adds a fallback for archive mode which force sets hash mode.
Rationale
N/A
Example
N/A
Changes
Notable changes: