Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: move tx indexer to its own file #2187

Closed
wants to merge 3 commits into from

Conversation

fynnss
Copy link
Contributor

@fynnss fynnss commented Jan 26, 2024

Description

This pull request moves all the transaction indexing functions to a separate txindexer.go file and define a txIndexer structure as a refactoring.

For reviewers, the core functions(indexing/unindexing) are not changed, just the refactor.

It helps us to separate data by data pattern

Refer to: ethereum/go-ethereum#28857

Rationale

NA

Example

NA

Changes

Notable changes:

  • Refactor TxIndex

@fynnss fynnss requested review from buddh0 and RenRick January 26, 2024 08:23
@fynnss fynnss force-pushed the refactor_tx_index branch 3 times, most recently from f767f95 to 7487909 Compare January 29, 2024 02:52
@fynnss fynnss added r4r ready for review X-storage task filter for storage issues, features, improve labels Jan 30, 2024
@fynnss
Copy link
Contributor Author

fynnss commented Feb 3, 2024

Will be merged together with Cancun code merge. #2200

@fynnss fynnss closed this Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r4r ready for review X-storage task filter for storage issues, features, improve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants