Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sensors-logging: Improve code that generates the subtitle dialogs #776

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sensors-logging: Improve code that generates the subtitle dialogs #776

wants to merge 1 commit into from
+35 −7

Conversation

patrickelectric
Copy link
Member

Based over #739 as a replacement

@patrickelectric patrickelectric mentioned this pull request Feb 27, 2024
Merged
@patrickelectric @rafaellehmkuhl
sensors-logging: Fix calculation of duration intervals to consider mi…
88490cd 
…lliseconds

Signed-off-by: Patrick José Pereira <[email protected]>
Co-authored-by: Rafael Araujo Lehmkuhl <[email protected]>
@rafaellehmkuhl
Copy link
Member

I think we should indeed pursue this change in the code, as it's clearly better in terms of organization and readability. We just need to make sure it does not introduce bugs.

From my tests last week, I recorded 3 footages. Two of them went fine, while the second one had a problem (line 34) where the time went backwards. The subtitle file is below.

Cockpit (Feb 22, 2024 - 17꞉28꞉00 GMT-3).ass.zip

@patrickelectric
Copy link
Member Author

I think we should indeed pursue this change in the code, as it's clearly better in terms of organization and readability. We just need to make sure it does not introduce bugs.

From my tests last week, I recorded 3 footages. Two of them went fine, while the second one had a problem (line 34) where the time went backwards. The subtitle file is below.

Cockpit (Feb 22, 2024 - 17꞉28꞉00 GMT-3).ass.zip

The tests were not done from the PR itself but from the snippets provided on the review.
While testing the full code, as provided in this PR, I believe that I was unable to replicate such problem.

Cockpit-Video-Recovery.zip

@rafaellehmkuhl rafaellehmkuhl changed the title sensors-logging: Fix calculation of duration intervals to consider milliseconds sensors-logging: Improve code that generates the subtitle dialogs Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickelectric @rafaellehmkuhl