Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute vs relative import #1263

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

patrickelectric
Copy link
Member

No description provided.

Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Since you're trying to make imports consistent, could you do that by adding an eslint rule the enforces it? From what I see here there are 35 files in the repository also using relative imports, so I don't see much sense on modifying only those 3.
  2. There's no need for 3 commits to do what is basically one logic change (for a matter of fact the first two without the third would be blocked by CI). In this PR you can see how we are dealing with linting commits, so we don't spam the repository with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants