-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chain enum and UnsupportedChainException (python) #20
base: master
Are you sure you want to change the base?
Conversation
Creates a method off the Chain enum for getting all the supported chains. Also, it creates a custom exception use this options() method to raise when the given chain is not one of the supported chains.
Questions about the documentation, end of line 71 in
1.). Where is this I actually suspect this is referring to |
Summary
Creates chain constants such as "mainnet" or "goerli" now accessible as Chain.MAINNET or Chain.GOERLI. Replaces the use of these constants through the code to use the available constants.
Other Information
This afford Pycharm type hints and allows the same constants to not have to be redefined down stream in apps/libs that use this library. It also makes the code look more polished.
Finally, if your pull request affects documentation or any non-code
changes, please explain.
Thanks for contributing to incubed! -->
I updated the documentation to show using these constants in cases where the chain name was being specified.