MB-62230: Update VectorIndexReader interface compliant to [email protected] #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
abhinavdangeti
commented
Sep 9, 2024
abhinavdangeti
commented
- If VectorReaderWithFilter has filterIDs != 1, the document is not eligible while pre-filtering.
- Also upgrade GO version and workflows.
abhinavdangeti
requested review from
Thejas-bhat,
metonymic-smokey,
CascadingRadium,
Likith101 and
moshaad7
abhinavdangeti
force-pushed
the
mb62230_apichange
branch
from
9bfd790
to
5d01ce6
Compare
Pull Request Test Coverage Report for Build 10779419897Details
💛 - Coveralls |
+ If VectorReaderWithFilter has filterIDs != 1, the document is not eligible while pre-filtering. + Also upgrade GO version and workflows.
abhinavdangeti
force-pushed
the
mb62230_apichange
branch
from
5d01ce6
to
5fad8a4
Compare
abhinavdangeti
changed the title
|
@metonymic-smokey must include this change as well while absorbing [email protected] into |
|
Available with blevesearch/[email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.