FR language translation fixes. #1250
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In fact, it is sufficient to just do the .ts changes, as I will compile the .qm files. |
|
For longterm, it might be nice to have a gh action to compile that, but I don't expect translations to change frequently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem I have with correcting the documentation is that a translator shouldn't have to update via pyside6-lrelease. I think a pre-commit hook system should be set up so that changes to .ts files are made at the same time as changes to ui and python files. If you're interested, I can try to set up such a system at https://github.com/ukaea/pyuic-pre-commit .