Fixing issues with controller in entry_sdl.cpp, introduces change in behavior. #3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDL2's concept of GameController is a like a PS or Xbox controller, two sticks, four face buttons, etc. These are the same as the bgfx example's Gamepad. SDL also has a concept of Joystick, which could be anything, like a flight stick. Game Controllers are implemented by these lower level joystick's. Entry SDL gets duplicate events, for both controller and the joystick implementing it. Game controller buttons are remapped to bgfx gamepad, but joystick buttons are not. This causes incorrect button presses. Additionally, the joystick z axis behaves differently than game controller or bgfx gamepad. With at-rest value being negative, not zero. Due to all of this, it seems like the best approach would be to ignore joystick events and only handle game controller events. Also, minor additional fix to get handle's index when using it as array index. Fixes compilation in Visual Studio.
elvencache
commented
Jul 7, 2024
|
|
||
| if (isValid(handle) ) | ||
| { | ||
| Key::Enum key = translateGamepad(bev.button); |
There was a problem hiding this comment.
JoyButtons are different than ControllerButtons. translateGamepad produces wrong key for some joy buttons.
This affects ThumbLeft/Right, ShoulderLeft/Right, Back, Start, and Guide.
elvencache
commented
Jul 7, 2024
| , true | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
Removing this code above stops the dpad buttons from being pressed when either stick is moved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running into 3 issues with example entry's SDL2 implementation.
Entry SDL gets duplicate events, for both controller and the joystick implementing it. Game controller buttons are remapped to bgfx gamepad, but joystick buttons are not. This causes joystick events to produce incorrect button presses.
Additionally, the joystick z-axis behaves differently than game controller or bgfx gamepad. With at-rest value being negative, not zero.
Due to all of this, it seems like the best approach would be to ignore joystick events and only handle game controller events.
I think the best approach would be to let the sticks register as sticks and the dpad to be left alone. User code could then choose to respond to left stick and dpad in the same way, or not.
Not sure if this change should be made or not, as it changes behavior for subjective reason and not correctness reason.