Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fixes for bulk assign buttons #728

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Fix: fixes for bulk assign buttons #728

merged 5 commits into from
Sep 30, 2024

Conversation

TheDancingClown
Copy link
Contributor

📝 A short description of the changes

  • Adds anchor to redirect to error message on validation failure
  • Hides award year dropdown when javascript disabled.
  • Updates save_or_load_search! method to include year params. When using the award year dropdown, the search_id is passed in the params but is not updated with the new year param. A check is therefore done to update the search record if the params[:year] does not match.
  • When javascript is disabled, a new search record is created. Therefore the search param is removed from the redirect here as we instead use the year from the search record.
  • Increases width of the success banner.
  • Adds new copy for bulk assign assessors.

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

  • None

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

Copy link
Contributor

@Lubosky Lubosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good, just one minor change

app/controllers/concerns/form_answer_mixin.rb Outdated Show resolved Hide resolved
@TheDancingClown TheDancingClown merged commit bafd8a8 into main Sep 30, 2024
5 of 6 checks passed
@TheDancingClown TheDancingClown deleted the bulk-qa branch September 30, 2024 16:16
@TheDancingClown TheDancingClown mentioned this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants