Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Python Workflow - Fix logic #1102

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Conversation

vgrassia
Copy link
Member

📔 Objective

This PR updates the Release Python SDK workflow to fix some logic. The version in the setup job was being echoed to GITHUB_ENV instead of GITHUB_OUTPUT. The downloaded artifacts were all in separate directories, so I moved them all to a single directory to allow them to be uploaded to the GitHub release draft.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vgrassia vgrassia self-assigned this Sep 30, 2024
@vgrassia vgrassia requested a review from a team as a code owner September 30, 2024 16:12
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsd65dae66-fe21-4e99-92b0-6540705567e8

No New Or Fixed Issues Found

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.44%. Comparing base (c33f82a) to head (c28233b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1102   +/-   ##
=======================================
  Coverage   58.44%   58.44%           
=======================================
  Files         192      192           
  Lines       13528    13528           
=======================================
  Hits         7907     7907           
  Misses       5621     5621           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgrassia vgrassia merged commit fa7a02c into main Sep 30, 2024
91 of 93 checks passed
@vgrassia vgrassia deleted the fix-version-output-python branch September 30, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants