Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRE-339] Fix Swift release workflow - artifact zip #1071

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

michalchecinski
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BRE-339

📔 Objective

When unpack the created artifact it takes the name of the zip file. It should unpack as BitwardenFFI.xcframework.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@michalchecinski michalchecinski changed the title Zip BitwardenFFI.xcframework as aditional step [BRE-339] Fix Swift release workflow - artifact zip Sep 20, 2024
Copy link
Contributor

github-actions bot commented Sep 20, 2024

Logo
Checkmarx One – Scan Summary & Details68e14236-ab6d-404c-94d7-1bf511cbf6c7

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build-swift.yml: 96 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /build-swift.yml: 91

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.12%. Comparing base (88537a8) to head (8552dcf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1071   +/-   ##
=======================================
  Coverage   58.12%   58.12%           
=======================================
  Files         197      197           
  Lines       13532    13532           
=======================================
  Hits         7865     7865           
  Misses       5667     5667           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michalchecinski michalchecinski marked this pull request as ready for review September 20, 2024 14:05
@michalchecinski michalchecinski requested a review from a team as a code owner September 20, 2024 14:05
@michalchecinski michalchecinski enabled auto-merge (squash) September 20, 2024 15:14
@michalchecinski michalchecinski merged commit 3cb295c into main Sep 20, 2024
82 of 84 checks passed
@michalchecinski michalchecinski deleted the BRE-339-Fix-Swift-release-workflow branch September 20, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants