Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Java installation instructions for Windows #1043

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

vphan916
Copy link
Contributor

🎟️ Tracking

📔 Objective

Added how to install Java for Windows

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Sep 13, 2024

Logo
Checkmarx One – Scan Summary & Details9953ac82-064d-4371-a6cf-9a562b67f457

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Privacy_Violation /languages/cpp/examples/Wrapper.cpp: 106 Attack Vector
LOW Privacy_Violation /languages/cpp/examples/Wrapper.cpp: 93 Attack Vector
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 143 Attack Vector

Fixed Issues

Severity Issue Source File / Package
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 159
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 129
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 122
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 115
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 151
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 129
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 159
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 115
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 151
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 159
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 129
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 151
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 129
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 159
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 122
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 115
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 151
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 129
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 159
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 159
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 136

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.11%. Comparing base (56fc75d) to head (fba7f41).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1043   +/-   ##
=======================================
  Coverage   58.11%   58.11%           
=======================================
  Files         197      197           
  Lines       13531    13531           
=======================================
  Hits         7864     7864           
  Misses       5667     5667           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tangowithfoxtrot tangowithfoxtrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

languages/java/INSTALL.md Outdated Show resolved Hide resolved
Copy link
Member

@coltonhurst coltonhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @vphan916 😄


Download JDK17

Go to System Environment Variables and point JAVA_HOME to where the JDK software is located, for example: JAVA_HOME=C:\Program Files\Java\jdk1.6.0_02.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Go to System Environment Variables and point JAVA_HOME to where the JDK software is located, for example: JAVA_HOME=C:\Program Files\Java\jdk1.6.0_02.
Go to System Environment Variables and point `JAVA_HOME` to where the JDK software is located, for example: `JAVA_HOME=C:\Program Files\Java\jdk1.6.0_02`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants