Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13674] Update GH Page Theme #92

Merged
merged 3 commits into from
Oct 22, 2024
Merged

[PM-13674] Update GH Page Theme #92

merged 3 commits into from
Oct 22, 2024

Conversation

vvolkgang
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13674

📔 Objective

Updates our GitHub Page theme with the goal of fixing README rendering issues.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang requested a review from a team as a code owner October 22, 2024 14:40
Copy link

Logo
Checkmarx One – Scan Summary & Details8ba983c6-616d-43fc-84fd-171a19fc3ba6

No New Or Fixed Issues Found

@vvolkgang vvolkgang enabled auto-merge (squash) October 22, 2024 14:49
minima:
skin: auto
social_links:
- { platform: github, user_url: "https://github.com/bitwarden/f-droid" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ Is the extra spacing needed?

@vvolkgang vvolkgang merged commit d9d7f89 into main Oct 22, 2024
5 checks passed
@vvolkgang vvolkgang deleted the update-theme branch October 22, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants