Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-102559] Fix fdroid workflow failure #49

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

SaintPatrck
Copy link
Contributor

@SaintPatrck SaintPatrck commented Sep 25, 2024

๐ŸŽŸ๏ธ Tracking

PM-12559

๐Ÿ“” Objective

Write commit message when the main repo index is updated.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link

github-actions bot commented Sep 25, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ b814e7bc-1a84-4f6f-984c-41f8e9c5ffa7

No New Or Fixed Issues Found

@SaintPatrck SaintPatrck force-pushed the PM-12559/fix-fdroid-workflow branch 2 times, most recently from 35e2fde to 48fa7f9 Compare September 25, 2024 17:51
@SaintPatrck SaintPatrck marked this pull request as ready for review September 25, 2024 17:57
@SaintPatrck SaintPatrck requested a review from a team as a code owner September 25, 2024 17:57
@SaintPatrck SaintPatrck merged commit 27f8cea into main Sep 25, 2024
5 checks passed
@SaintPatrck SaintPatrck deleted the PM-12559/fix-fdroid-workflow branch September 25, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants