[PM-12559] Improve conditional update logic #48
Merged
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a step to update the F-Droid repository based on certain conditions: - Skips updates if it's a dry run - Skips updates if no changes were detected by the metascoop step - Runs the update_repo.sh script if changes were detected and it's not a dry run This ensures that the repository is only updated when necessary, improving efficiency and avoiding unnecessary commits.
|
No New Or Fixed Issues Found |
SaintPatrck
changed the title
vvolkgang
reviewed
Sep 23, 2024
| @@ -122,6 +122,11 @@ jobs: | |||
| - name: Update repo | |||
| env: | |||
| GH_TOKEN: ${{ steps.retrieve-secrets.outputs.github-pat-bitwarden-devops-bot-repo-scope }} | |||
| if: ${{ (github.event_name == 'schedule' || inputs.dry-run == 'false') && steps.run-metascoop.outputs.has_changes == 'true' }} | |||
There was a problem hiding this comment.
Looking at this now, this was probably comparing bools with strings. The new changes will work due to converting them to strings first. If that's correct, this should work too:
if: ${{ (github.event_name == 'schedule' || inputs.dry-run == false) && steps.run-metascoop.outputs.has_changes == true }}
There was a problem hiding this comment.
Good catch! I actually prefer having the verbose output though. It gives us a better idea of why changes are or are not being saved.
vvolkgang
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-12559
📔 Objective
This PR modifies the workflow to update the F-Droid repository based on certain conditions:
dry-runupdate_repo.shscript if changes were detected and it's not a dry runThis ensures that the repository is updated when necessary.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes