Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12502] Update app descriptions #45

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Conversation

SaintPatrck
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12502

📔 Objective

Update application descriptions to match their Play Store descriptions.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@SaintPatrck SaintPatrck requested a review from a team as a code owner September 23, 2024 19:12
Copy link

github-actions bot commented Sep 23, 2024

Logo
Checkmarx One – Scan Summary & Details83baffec-428d-427a-bea2-45d8f2c63657

No New Or Fixed Issues Found

vvolkgang
vvolkgang previously approved these changes Sep 23, 2024
Copy link
Member

@vvolkgang vvolkgang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! One suggestion:

🎨 GitHub syntax highlight isn't handling the other fields properly, maybe moving them before the description would help?

@SaintPatrck SaintPatrck force-pushed the PM-12502/update-app-descriptions branch from b630705 to 6d902e2 Compare September 23, 2024 19:55
Copy link
Member

@vvolkgang vvolkgang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked! 👏

@vvolkgang vvolkgang merged commit be86d91 into main Sep 23, 2024
5 checks passed
@vvolkgang vvolkgang deleted the PM-12502/update-app-descriptions branch September 23, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants