[PM-7276] Setup Bitwarden F-Droid repo #3
Conversation
|
New Issues
|
.github/workflows/fdroid.yml
Outdated
| - name: Configure F-Droid server | ||
| env: | ||
| FDROID_STORE_KEYSTORE_PASSWORD: ${{ secrets.FDROID_STORE_KEYSTORE_PASSWORD }} | ||
| run: | | ||
| chmod 600 fdroid/config.yml | ||
| echo "keypass: $FDROID_STORE_KEYSTORE_PASSWORD" >> fdroid/config.yml | ||
| echo "keystorepass: $FDROID_STORE_KEYSTORE_PASSWORD" >> fdroid/config.yml | ||
| echo "archive_older: 0" >> fdroid/config.yml | ||
| echo "repo_url: https://raw.githubusercontent.com/bitwarden/fdroid/main/fdroid/repo" >> fdroid/config.yml |
There was a problem hiding this comment.
This is how the current F-Droid config.yml is being constructed in bitwarden/mobile. Depending on how https://bitwarden.atlassian.net/servicedesk/customer/portal/5/TSD-797 is resolved, this may change. I have recommended that config.yml be stored as a precompiled file in Azure Vault instead of compiling it during workflow execution.
There was a problem hiding this comment.
Storing the completed config.yml file in an Azure Storage Account will work great.
| git config --local user.name 'Bitwarden CI' | ||
| git config --local user.email '[email protected]' |
There was a problem hiding this comment.
Double check these values are correct. They were copied from the bitwarden/mobile workflow.
There was a problem hiding this comment.
@vgrassia Is this ok for this PR? As a future enhancement, should we transition to the version bump automation pattern using the devops bot?
There was a problem hiding this comment.
I would say keep it this way for now as it seems clearer instead of using the DevOps bot pattern.
.github/workflows/fdroid.yml
Outdated
| - name: Configure F-Droid server | ||
| env: | ||
| FDROID_STORE_KEYSTORE_PASSWORD: ${{ secrets.FDROID_STORE_KEYSTORE_PASSWORD }} | ||
| run: | | ||
| chmod 600 fdroid/config.yml | ||
| echo "keypass: $FDROID_STORE_KEYSTORE_PASSWORD" >> fdroid/config.yml | ||
| echo "keystorepass: $FDROID_STORE_KEYSTORE_PASSWORD" >> fdroid/config.yml | ||
| echo "archive_older: 0" >> fdroid/config.yml | ||
| echo "repo_url: https://raw.githubusercontent.com/bitwarden/fdroid/main/fdroid/repo" >> fdroid/config.yml |
There was a problem hiding this comment.
Storing the completed config.yml file in an Azure Storage Account will work great.
SaintPatrck
force-pushed
the
PM-7276/setup-fdroid-distribution
branch
from
3435812
to
1daeb8b
Compare
| git config --local user.email '[email protected]' | ||
|
|
||
| git add . | ||
| git commit -m"Automated update" |
There was a problem hiding this comment.
More of a note to self and nothing we need to change in this PR, listing the apps that were updated would be a visibility / transparency quick win 🤔
There was a problem hiding this comment.
Awesome work here @SaintPatrck ! 👏🏾
We defined a list of enhancements for future PRs, as is this PR will help us test the whole process and see if we missed anything.
Warning
For the time being this will process GitHub Pre-releases as normal releases. This is an intentional decision for testing purposes, so we can find any issues ahead of our GA update release. Pre-release prod builds will be removed from the F-Droid repo when we're done.
Co-authored-by: Vince Grassia <[email protected]>
🎟️ Tracking
PM-7276
📔 Objective
Setup Bitwarden F-Droid repository.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes