Skip to content

Commit

Permalink
[PM-4747] List members under each group when doing test sync (#507)
Browse files Browse the repository at this point in the history
* Add user list under each group when doing test sync

* run prettier and lint, replace '@' with @
  • Loading branch information
r-tome authored Jul 23, 2024
1 parent 63b06f6 commit 6e76d8f
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 10 deletions.
2 changes: 1 addition & 1 deletion jslib/angular/src/services/auth-guard.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { StateService } from "@/jslib/common/src/abstractions/state.service";
import { VaultTimeoutService } from "@/jslib/common/src/abstractions/vaultTimeout.service";

@Injectable()
export class AuthGuardService {
export class AuthGuardService {
constructor(
private vaultTimeoutService: VaultTimeoutService,
private router: Router,
Expand Down
2 changes: 1 addition & 1 deletion jslib/angular/src/services/lock-guard.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { StateService } from "@/jslib/common/src/abstractions/state.service";
import { VaultTimeoutService } from "@/jslib/common/src/abstractions/vaultTimeout.service";

@Injectable()
export class LockGuardService {
export class LockGuardService {
protected homepage = "vault";
protected loginpage = "login";
constructor(
Expand Down
2 changes: 1 addition & 1 deletion jslib/angular/src/services/unauth-guard.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { StateService } from "@/jslib/common/src/abstractions/state.service";
import { VaultTimeoutService } from "@/jslib/common/src/abstractions/vaultTimeout.service";

@Injectable()
export class UnauthGuardService {
export class UnauthGuardService {
protected homepage = "vault";
constructor(
private vaultTimeoutService: VaultTimeoutService,
Expand Down
1 change: 0 additions & 1 deletion jslib/common/src/misc/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { I18nService } from "../abstractions/i18n.service";

import * as tldjs from "tldjs";


const nodeURL = typeof window === "undefined" ? require("url") : null;

export class Utils {
Expand Down
2 changes: 1 addition & 1 deletion jslib/electron/src/services/electronLog.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export class ElectronLogService extends BaseLogService {
super(isDev(), filter);
}

init () {
init() {
if (log.transports == null) {
return;
}
Expand Down
5 changes: 5 additions & 0 deletions src/app/tabs/dashboard.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,11 @@ <h4>{{ "groups" | i18n }}</h4>
<li *ngFor="let g of simGroups" title="{{ g.referenceId }}">
<i class="bwi bwi-li bwi-sitemap"></i>
{{ g.displayName }}
<ul class="small" *ngIf="g.users && g.users.length">
<li *ngFor="let u of g.users" title="{{ u.referenceId }}">
{{ u.displayName }}
</li>
</ul>
</li>
</ul>
<p *ngIf="!simGroups || !simGroups.length">{{ "noGroups" | i18n }}</p>
Expand Down
10 changes: 5 additions & 5 deletions src/app/tabs/settings.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ <h3 class="card-header">{{ "directory" | i18n }}</h3>
name="AdminUser"
[(ngModel)]="gsuite.adminUser"
/>
<small class="text-muted form-text">{{ "ex" | i18n }} admin@company.com</small>
<small class="text-muted form-text">{{ "ex" | i18n }} admin&#64;company.com</small>
</div>
<div class="form-group">
<label for="customerId">{{ "customerId" | i18n }}</label>
Expand Down Expand Up @@ -596,7 +596,7 @@ <h3 class="card-header">{{ "sync" | i18n }}</h3>
name="EmailSuffix"
[(ngModel)]="sync.emailSuffix"
/>
<small class="text-muted form-text">{{ "ex" | i18n }} @company.com</small>
<small class="text-muted form-text">{{ "ex" | i18n }} &#64;company.com</small>
</div>
</div>
</div>
Expand Down Expand Up @@ -628,13 +628,13 @@ <h3 class="card-header">{{ "sync" | i18n }}</h3>
<small
class="text-muted form-text"
*ngIf="directory === directoryType.AzureActiveDirectory"
>{{ "ex" | i18n }} exclude:joe@company.com</small
>{{ "ex" | i18n }} exclude:joe&#64;company.com</small
>
<small class="text-muted form-text" *ngIf="directory === directoryType.Okta"
>{{ "ex" | i18n }} exclude:joe@company.com | profile.firstName eq "John"</small
>{{ "ex" | i18n }} exclude:joe&#64;company.com | profile.firstName eq "John"</small
>
<small class="text-muted form-text" *ngIf="directory === directoryType.GSuite"
>{{ "ex" | i18n }} exclude:joe@company.com | orgName=Engineering</small
>{{ "ex" | i18n }} exclude:joe&#64;company.com | orgName=Engineering</small
>
</div>
<div class="form-group" [hidden]="directory != directoryType.Ldap">
Expand Down
2 changes: 2 additions & 0 deletions src/models/groupEntry.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import { Entry } from "./entry";
import { UserEntry } from "./userEntry";

export class GroupEntry extends Entry {
name: string;
userMemberExternalIds = new Set<string>();
groupMemberReferenceIds = new Set<string>();
users: UserEntry[] = [];

get displayName(): string {
if (this.name == null) {
Expand Down

0 comments on commit 6e76d8f

Please sign in to comment.