[PM-13901] Bugfix for "Ask for biometrics on launch does not auto prompt biometrics" #12144
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #12144 +/- ##
==========================================
- Coverage 33.48% 33.48% -0.01%
==========================================
Files 2874 2875 +1
Lines 89821 89829 +8
Branches 17102 17102
==========================================
Hits 30075 30075
- Misses 57370 57378 +8
Partials 2376 2376 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Fixed Issues
|
rr-bw
requested review from
Patrick-Pimentel-Bitwarden and
JaredSnider-Bitwarden
and removed request for
Patrick-Pimentel-Bitwarden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13901
📔 Objective
This PR ensures that, on the browser extension, biometrics gets auto-prompted when user selects "Ask for biometrics on launch" by resetting the
isInitialLockScreentotrueon active account change.The issue was that the
previousUrl(see here) was maintaining a value , e.g. "/lockV2", which preventedunlockViaBiometrics()from being run here. Therefore this PR resets theisInitialLockScreentotruewhenresetDataOnActiveAccountChange()is run.Feature flag:
ExtensionRefreshON.📸 Screenshots
Chrome
chrome-auto-prompt.mov
Safari
safari-auto-prompt.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes