Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15171] Move access intelligence feature under bitwarden_license #12116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

djsmith85
Copy link
Contributor

@djsmith85 djsmith85 commented Nov 23, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15171

📔 Objective

Due to the wrong file locations some of the code was referencing/importing bitwarden-licensed code and would have prevented building/publishing OSS web.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.

Project coverage is 33.47%. Comparing base (341a93a) to head (b2f9b54).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../access-intelligence/all-applications.component.ts 0.00% 3 Missing ⚠️
...ss-intelligence/critical-applications.component.ts 0.00% 3 Missing ⚠️
...-intelligence/password-health-members.component.ts 0.00% 3 Missing ⚠️
...sole/organizations/organizations-routing.module.ts 0.00% 2 Missing ⚠️
...ols/access-intelligence/risk-insights.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12116   +/-   ##
=======================================
  Coverage   33.47%   33.47%           
=======================================
  Files        2875     2875           
  Lines       89828    89828           
  Branches    17102    17102           
=======================================
  Hits        30068    30068           
  Misses      57384    57384           
  Partials     2376     2376           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsdf6b77f5-ab87-4933-85ce-574d37ffb06d

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Client_JQuery_Deprecated_Symbols /apps/cli/src/service-container/service-container.ts: 876 Attack Vector

@djsmith85 djsmith85 marked this pull request as ready for review November 23, 2024 10:40
@djsmith85 djsmith85 requested review from a team as code owners November 23, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant