[PM-13348] Browser Extension impacts on Free Bitwarden Family Policy #12073
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12073 +/- ##
==========================================
- Coverage 33.47% 33.46% -0.02%
==========================================
Files 2875 2876 +1
Lines 89830 89856 +26
Branches 17102 17106 +4
==========================================
- Hits 30075 30068 -7
- Misses 57379 57412 +33
Partials 2376 2376 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Fixed Issues
|
| (organizations) => organizations.filter((org) => org.canManageSponsorships).length === 1, | ||
| ), |
There was a problem hiding this comment.
🤔 Is it more defensive to test === 1 or >=1 here? Same applies to line 58.
There was a problem hiding this comment.
We are considering only when there is 1 enterprise organization, and when the policy is turned on
| map((organizations) => organizations.filter((org) => org.canManageSponsorships)), | ||
| switchMap((enterpriseOrgs) => { | ||
| if (enterpriseOrgs.length === 1) { | ||
| const enterpriseOrgId = enterpriseOrgs[0].id; |
There was a problem hiding this comment.
🤔 This seems incorrect. Shouldn't you check all enterprise orgs? If not, document why the first one is the one you should always check.
| ), | ||
| ); | ||
|
|
||
| this.isFreeFamilyPolicyEnabled$ = this.organizationService.getAll$().pipe( |
There was a problem hiding this comment.
🤔 This code is duplicated across multiple components. That indicates to me that it should be encapsulated within a service.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13348
📔 Objective
Given the users email address is only associated with 1 enterprise organization, when the policy is turned on, then hide the Free Bitwarden Families page from the navigation in the updated extension navigation (Settings > About > More from Bitwarden)
Design: Extension refresh
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes