[PM-7382] Add support for non-UUID credential #11993
Conversation
Technically this deviates from the specification, but nobody is going to be using the authenticator directly but us so it shouldn't matter. We're gonna switch to `passkey-rs` anyways so
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #11993 +/- ##
==========================================
+ Coverage 33.48% 33.49% +0.01%
==========================================
Files 2844 2845 +1
Lines 89044 89057 +13
Branches 16987 16990 +3
==========================================
+ Hits 29812 29827 +15
+ Misses 56887 56885 -2
Partials 2345 2345 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Fixed Issues
|
| @@ -64,7 +64,7 @@ export class Fido2AuthenticatorError extends Error { | |||
| } | |||
|
|
|||
| export interface PublicKeyCredentialDescriptor { | |||
| id: BufferSource; | |||
| id: Uint8Array; | |||
There was a problem hiding this comment.
General question, should be interface be prescriptive enough about the ID to define it as Uint8Array, or use ArrayBuffer? I don't see an issue sticking with Uint8Array though.
There was a problem hiding this comment.
I actually commented this in the commit. I don't think it matters
refactor: change interface to use Uint8Array for simplification
Technically this deviates from the specification, but nobody is going to be using the authenticator directly but us so it shouldn't matter. We're gonna switch topasskey-rsanyways so
|
|
||
| export function parseCredentialId(encodedCredentialId: string): Uint8Array { | ||
| try { | ||
| if (encodedCredentialId.startsWith("b64.")) { |
There was a problem hiding this comment.
I hate it, but let's run with it.
| /** | ||
| * Compares two credential IDs for equality. | ||
| */ | ||
| export function compareCredentialIds(a: Uint8Array, b: Uint8Array): boolean { |
There was a problem hiding this comment.
We may benefit from having a general util function for comparing Uint8Arrays.
There was a problem hiding this comment.
Yeah but you've always stopped me when adding functions to the general utils in the past so now I'm going by "if we use it twice put it in general" XD
🎟️ Tracking
📔 Objective
Implement support for
credentialIdsencoded as Base64. This does not change how newcredentialIdsare created, this is on purpose so that we don't break older clients📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes