Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10719] Defect card holder name not auto filling #11780

Merged

Conversation

dan-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10719

📔 Objective

Added accountholdername to the cardholder field names and values constants. This update should help mitigate the issue where the Amazon credit card pop-up is not auto-filling the cardholder name field.

📸 Screenshots

Screenshot 2024-10-29 at 3 39 19 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

…ociated with the cardholder field. This update should help mitigate issues where the Amazon credit card pop-up is not auto-filling the cardholder name field.
@dan-livefront dan-livefront self-assigned this Oct 29, 2024
@dan-livefront dan-livefront requested a review from a team as a code owner October 29, 2024 19:44
@dan-livefront dan-livefront changed the title fix:Add accountHolderName to the field names and values constants ass… PM-10719 Defect card holder name not auto filling Oct 29, 2024
@dan-livefront dan-livefront changed the title PM-10719 Defect card holder name not auto filling [PM-10719] Defect card holder name not auto filling Oct 29, 2024
@dan-livefront dan-livefront requested review from djsmith85 and removed request for djsmith85 October 29, 2024 20:56
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.50%. Comparing base (2539a1d) to head (56a50dc).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11780      +/-   ##
==========================================
- Coverage   33.51%   33.50%   -0.01%     
==========================================
  Files        2815     2815              
  Lines       87546    87546              
  Branches    16684    16684              
==========================================
- Hits        29339    29332       -7     
- Misses      55900    55907       +7     
  Partials     2307     2307              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dan-livefront dan-livefront merged commit b0a73cf into main Nov 1, 2024
25 of 26 checks passed
@dan-livefront dan-livefront deleted the PM-10719-defect-cardholder-name-is-not-autofilling branch November 1, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants