PM-15147 - Design Audit - Master Password Guidance Screen #4383
+176
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues
Fixed Issues
|
phil-livefront
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4383 +/- ##
=======================================
Coverage 89.01% 89.01%
=======================================
Files 451 451
Lines 39129 39142 +13
Branches 5534 5534
=======================================
+ Hits 34831 34844 +13
Misses 2370 2370
Partials 1928 1928 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
| contentDescription = stringResource(id = R.string.close), | ||
| onClick = onDismissClick, | ||
| ) | ||
| onDismissClick?.let { |
| @Preview | ||
| @Preview(uiMode = Configuration.UI_MODE_NIGHT_YES) | ||
| @Composable | ||
| private fun BitwardenActionCardWithSubtitleNoDismiss_preview() { |
| .fillMaxWidth() | ||
| .padding(horizontal = 16.dp), | ||
| ) | ||
| Spacer(modifier = Modifier.height(24.dp)) |
There was a problem hiding this comment.
⛏️ maybe minor thing, curious what others thoughts are with this, maybe we can just remove the wrapping Columns and have it so at the call site its like
Column {
ContentItem1()
Spacer()
ContentItem2()
etc.
}
| cardTitle = stringResource(R.string.need_some_inspiration), | ||
| actionText = stringResource(R.string.check_out_the_passphrase_generator), | ||
| onActionClick = onActionClicked, | ||
| modifier = modifier |
There was a problem hiding this comment.
⛏️ this is Okay as is, but could also just be same line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15147
📔 Objective
BitwardenActionCardto include an optional dismiss action, supporting scenarios like the MasterPasswordGuidanceScreen where no dismiss action is required.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes