Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit characters [+@.] from allowed usernames on registration and e-mail validation #154

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions web/src/p2k16/core/account_management.py
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,12 @@ def register_account(username: str, email: str, name: str, password: str, phone:
if " " in username:
raise P2k16UserException("Username cannot contain spaces")

if not re.match(r"^[a-zA-Z0-9@._+-]+$", username):
raise P2k16UserException("Username can only contain a-z, 0-9, @, ., _, + and -.")

if not re.match(r"^[A-z0-9_-]+$", username):
raise P2k16UserException("Username can only contain a-z, 0-9, _ and -.")

if not re.match(r"^[\w\.\-]+@([\w-]+\.)+[\w-]{2,4}$", email):
raise P2k16UserException("Email is not valid!")

account = Account(username, email, name, phone, password)
db.session.add(account)
return account
Expand Down