Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/argo-cd] Remove subchart image from values.yaml #30585

Closed
wants to merge 3 commits into from

Conversation

migruiz4
Copy link
Member

Description of the change

This PR removes the subchart image from the values.yaml

Benefits

The image tag will automatically use the version defined in the subchart.

Possible drawbacks

None known

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added argo-cd verify Execute verification workflow for these changes bitnami labels Nov 22, 2024
@migruiz4
Copy link
Member Author

Please ignore the 'Look for hardcoded images' check failure. It is being triggered because an image is being removed from the values.yaml

@migruiz4 migruiz4 closed this Nov 22, 2024
@carrodher carrodher deleted the argo-cd-remove-subchart-image branch November 27, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-cd bitnami solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants