-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding label for umbrella chart in case redis chart is being used as dependency #30491
base: main
Are you sure you want to change the base?
Conversation
Adding umbrellaChart name and version to set labels in case of umbrella chart setup Signed-off-by: Ankit Sahu <[email protected]>
adding function named "common.names.umbrellaChart" to print umbrella chart and and version Signed-off-by: Ankit Sahu <[email protected]>
adding label in case of umbrella chart setup helm.sh/umbrellaChart: {{ include "common.names.umbrellaChart" . }} Signed-off-by: Ankit Sahu <[email protected]>
Signed-off-by: Ankit Sahu <[email protected]>
bumping version for common lib Signed-off-by: Ankit Sahu <[email protected]>
Thank you for your PR! I wonder if you could use |
I believe, we can add some custom labels as per use cases. If anyone using redis bitnami chart as depednecy there is no provision that he/she can label their chart version in redis deployment |
updating readme
Updating values.schema.json
adding changelog
Description of the change
This change will provide flexibility to add labels where user will consume redis chart as dependency
Benefits
For any organization who is consuming redis chart as dependency would be able to have their own chart and version as label
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm