Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding label for umbrella chart in case redis chart is being used as dependency #30491

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ankitsahuknit
Copy link

@ankitsahuknit ankitsahuknit commented Nov 18, 2024

Description of the change

This change will provide flexibility to add labels where user will consume redis chart as dependency

Benefits

For any organization who is consuming redis chart as dependency would be able to have their own chart and version as label

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Adding umbrellaChart name and version to set labels in case of umbrella chart setup

Signed-off-by: Ankit Sahu <[email protected]>
adding function named "common.names.umbrellaChart" to print umbrella chart and and version

Signed-off-by: Ankit Sahu <[email protected]>
adding label in case of umbrella chart setup 

helm.sh/umbrellaChart: {{ include "common.names.umbrellaChart" . }}

Signed-off-by: Ankit Sahu <[email protected]>
Signed-off-by: Ankit Sahu <[email protected]>
bumping version for common lib

Signed-off-by: Ankit Sahu <[email protected]>
@carrodher
Copy link
Member

Thank you for your PR! I wonder if you could use commonLabels for this purpose. I'm not sure if there’s a standard label for this (perhaps kubernetes.io/part-of), but it looks like helm.sh/umbrellaChart doesn’t exist.

@ankitsahuknit
Copy link
Author

Thank you for your PR! I wonder if you could use commonLabels for this purpose. I'm not sure if there’s a standard label for this (perhaps kubernetes.io/part-of), but it looks like helm.sh/umbrellaChart doesn’t exist.

I believe, we can add some custom labels as per use cases. If anyone using redis bitnami chart as depednecy there is no provision that he/she can label their chart version in redis deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redis triage Triage is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants