Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/drupal] chore!: ⬆️ 💥 Bump MariaDB subchart to 20 #30352

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

javsalgar
Copy link
Contributor

BREAKING CHANGE

Signed-off-by: Javier J. Salmerón García [email protected]

Description of the change

This PR bumps the MariaDB subchart to version 20.x.x, in order to continue having automated updates without issues.

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added drupal verify Execute verification workflow for these changes bitnami labels Nov 8, 2024
@github-actions github-actions bot requested a review from juan131 November 8, 2024 15:10
Signed-off-by: Bitnami Containers <[email protected]>
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove deprecated values in this major bump:

$ grep -E "Deprecated:|DEPRECATED:" bitnami/drupal/values.yaml
## @param global.storageClass DEPRECATED: use global.defaultStorageClass instead
  ## DEPRECATED: Use ingress.annotations instead of ingress.certManager

Signed-off-by: Javier J. Salmerón García <[email protected]>
@juan131 juan131 enabled auto-merge (squash) November 12, 2024 11:05
juan131
juan131 previously approved these changes Nov 12, 2024
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Bitnami Containers <[email protected]>
@juan131 juan131 merged commit 3152c34 into main Nov 12, 2024
13 checks passed
@juan131 juan131 deleted the feat/drupal/major-mariadb-bump branch November 12, 2024 11:20
sajad-sadra pushed a commit to sajad-sadra/bitnami-charts that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami drupal solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants