-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/mysql] fix!: 🐛 ✨ 💥 Set correct serviceName and add Password Update Job #30351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Update Job Signed-off-by: Javier J. Salmerón García <[email protected]>
github-actions
bot
added
mysql
verify
Execute verification workflow for these changes
bitnami
labels
Nov 8, 2024
Signed-off-by: Javier J. Salmerón García <[email protected]>
Signed-off-by: Javier J. Salmerón García <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
juan131
requested changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this awesome PR! Please check my comments about copy-paste typos
Signed-off-by: Javier J. Salmerón García <[email protected]>
juan131
previously approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Bitnami Containers <[email protected]>
juan131
approved these changes
Nov 12, 2024
sajad-sadra
pushed a commit
to sajad-sadra/bitnami-charts
that referenced
this pull request
Nov 20, 2024
…Update Job (bitnami#30351) * [bitnami/mysql] fix!: 🐛 ✨ 💥 Set correct serviceName and add Password Update Job Signed-off-by: Javier J. Salmerón García <[email protected]> * docs: 📝 Update Parameter Table Signed-off-by: Javier J. Salmerón García <[email protected]> * docs: 🚨 Use proper link Signed-off-by: Javier J. Salmerón García <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * fix: 🐛 Set correct references Signed-off-by: Javier J. Salmerón García <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Javier J. Salmerón García <[email protected]> Signed-off-by: Bitnami Containers <[email protected]> Co-authored-by: Bitnami Containers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Description of the change
This PR fixes how the StatefulSets were using as
serviceName
a non-headless service. This was causing that DNS entries were not being registered. In addition to this, we add a new feature, a password update job. This job uses helm hooks to update the mysql passwords. This is disabled by default.Benefits
Correct usage of headless services and better password management
Possible drawbacks
Manual operation to update the statefulset
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm