Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/mysql] fix!: 🐛 ✨ 💥 Set correct serviceName and add Password Update Job #30351

Merged
merged 6 commits into from
Nov 12, 2024

Conversation

javsalgar
Copy link
Contributor

BREAKING CHANGE

Description of the change

This PR fixes how the StatefulSets were using as serviceName a non-headless service. This was causing that DNS entries were not being registered. In addition to this, we add a new feature, a password update job. This job uses helm hooks to update the mysql passwords. This is disabled by default.

Benefits

Correct usage of headless services and better password management

Possible drawbacks

Manual operation to update the statefulset

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added mysql verify Execute verification workflow for these changes bitnami labels Nov 8, 2024
@github-actions github-actions bot requested a review from fmulero November 8, 2024 14:43
javsalgar and others added 3 commits November 8, 2024 15:43
Signed-off-by: Javier J. Salmerón García <[email protected]>
Signed-off-by: Javier J. Salmerón García <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this awesome PR! Please check my comments about copy-paste typos

bitnami/mysql/README.md Outdated Show resolved Hide resolved
bitnami/mysql/README.md Outdated Show resolved Hide resolved
bitnami/mysql/templates/_helpers.tpl Outdated Show resolved Hide resolved
bitnami/mysql/values.yaml Outdated Show resolved Hide resolved
Signed-off-by: Javier J. Salmerón García <[email protected]>
juan131
juan131 previously approved these changes Nov 12, 2024
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Bitnami Containers <[email protected]>
@javsalgar javsalgar merged commit 21e98a5 into main Nov 12, 2024
14 checks passed
@javsalgar javsalgar deleted the feat/mysql-update-password branch November 12, 2024 11:34
sajad-sadra pushed a commit to sajad-sadra/bitnami-charts that referenced this pull request Nov 20, 2024
…Update Job (bitnami#30351)

* [bitnami/mysql] fix!: 🐛 ✨ 💥 Set correct serviceName and add Password Update Job

Signed-off-by: Javier J. Salmerón García <[email protected]>

* docs: 📝 Update Parameter Table

Signed-off-by: Javier J. Salmerón García <[email protected]>

* docs: 🚨 Use proper link

Signed-off-by: Javier J. Salmerón García <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

* fix: 🐛 Set correct references

Signed-off-by: Javier J. Salmerón García <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Javier J. Salmerón García <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Co-authored-by: Bitnami Containers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami mysql solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants