-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prerelease v-9.1.0-pre-02 (#9319) #9321
Prerelease v-9.1.0-pre-02 (#9319) #9321
Conversation
WalkthroughThe pull request includes updates to various files across the project, primarily focusing on incrementing the version number from Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
src/Bswup/Bit.Bswup/Scripts/bit-bswup.sw.ts (2)
Line range hint
133-146
: Consider extracting URL comparison logicThe URL comparison logic using dynamic method selection could be extracted into a helper function for better maintainability and reuse.
Consider refactoring to:
+ function compareUrls(url1: string, url2: string, caseInsensitive: boolean): boolean { + const method = caseInsensitive ? 'toLowerCase' : 'toString'; + return url1[method]() === url2[method](); + } - let asset = UNIQUE_ASSETS.find(a => a[shouldServeIndexHtml ? 'url' : 'reqUrl'][caseMethod]() === requestUrl[caseMethod]()); + let asset = UNIQUE_ASSETS.find(a => compareUrls(a[shouldServeIndexHtml ? 'url' : 'reqUrl'], requestUrl, self.caseInsensitiveUrl));
Line range hint
366-394
: Enhance error handling in cache operationsThe cache operations could benefit from more detailed error handling and logging, especially for network failures during asset fetching.
Consider enhancing the error handling:
async function addCache(report, asset) { const request = createNewAssetRequest(asset); try { const responsePromise = fetch(request); return responsePromise.then(async response => { try { if (!response.ok) { diag('*** addCache - !response.ok:', request); + diag('*** Response status:', response.status, response.statusText); doReport(true); return Promise.reject(response); } const cacheUrl = createCacheUrl(asset); await newCache.put(cacheUrl, response.clone()); doReport(); return response; } catch (err) { diag('*** addCache - put cache err:', err); + diag('*** Cache operation failed for asset:', asset.url); doReport(true); return Promise.reject(err); } }); } catch (err) { diag('*** addCache - catch err:', err); + diag('*** Network request failed for asset:', asset.url); doReport(true); return Promise.reject(err); }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (43)
src/Besql/Bit.Besql/wwwroot/bit-besql.js
(1 hunks)src/Bit.Build.props
(1 hunks)src/BlazorUI/Bit.BlazorUI/Scripts/general.ts
(1 hunks)src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj
(1 hunks)src/BlazorUI/Demo/Bit.BlazorUI.Demo.Shared/Bit.BlazorUI.Demo.Shared.csproj
(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Bit.BlazorUI.Demo.Client.Core.csproj
(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj
(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj
(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/wwwroot/service-worker.published.js
(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj
(1 hunks)src/BlazorUI/Demo/Directory.Build.props
(1 hunks)src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.js
(1 hunks)src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.published.js
(1 hunks)src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.js
(1 hunks)src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.published.js
(1 hunks)src/Bswup/Bit.Bswup/Scripts/bit-bswup.progress.ts
(1 hunks)src/Bswup/Bit.Bswup/Scripts/bit-bswup.sw.ts
(1 hunks)src/Bswup/Bit.Bswup/Scripts/bit-bswup.ts
(1 hunks)src/Bswup/FullDemo/Client/wwwroot/service-worker.js
(1 hunks)src/Bswup/FullDemo/Client/wwwroot/service-worker.published.js
(1 hunks)src/Bup/Bit.Bup/Scripts/bit-bup.progress.ts
(1 hunks)src/Bup/Bit.Bup/Scripts/bit-bup.ts
(1 hunks)src/Butil/Bit.Butil/Scripts/butil.ts
(1 hunks)src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty.Client/BlazorEmpty.Client.csproj
(2 hunks)src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty/BlazorEmpty.csproj
(2 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/wwwroot/service-worker.published.js
(1 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props
(1 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props
(2 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages8.props
(2 hunks)src/Websites/Careers/src/Bit.Websites.Careers.Client/Bit.Websites.Careers.Client.csproj
(1 hunks)src/Websites/Careers/src/Bit.Websites.Careers.Server/Bit.Websites.Careers.Server.csproj
(1 hunks)src/Websites/Careers/src/Bit.Websites.Careers.Shared/Bit.Websites.Careers.Shared.csproj
(1 hunks)src/Websites/Careers/src/Directory.Build.props
(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Bit.Websites.Platform.Client.csproj
(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor
(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor.cs
(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Server/Bit.Websites.Platform.Server.csproj
(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Shared/Bit.Websites.Platform.Shared.csproj
(1 hunks)src/Websites/Platform/src/Directory.Build.props
(1 hunks)src/Websites/Sales/src/Bit.Websites.Sales.Client/Bit.Websites.Sales.Client.csproj
(1 hunks)src/Websites/Sales/src/Bit.Websites.Sales.Server/Bit.Websites.Sales.Server.csproj
(1 hunks)src/Websites/Sales/src/Bit.Websites.Sales.Shared/Bit.Websites.Sales.Shared.csproj
(1 hunks)src/Websites/Sales/src/Directory.Build.props
(1 hunks)
✅ Files skipped from review due to trivial changes (32)
- src/Besql/Bit.Besql/wwwroot/bit-besql.js
- src/Bit.Build.props
- src/BlazorUI/Bit.BlazorUI/Scripts/general.ts
- src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj
- src/BlazorUI/Demo/Bit.BlazorUI.Demo.Shared/Bit.BlazorUI.Demo.Shared.csproj
- src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/wwwroot/service-worker.published.js
- src/BlazorUI/Demo/Directory.Build.props
- src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.js
- src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.published.js
- src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.js
- src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.published.js
- src/Bswup/Bit.Bswup/Scripts/bit-bswup.progress.ts
- src/Bswup/Bit.Bswup/Scripts/bit-bswup.ts
- src/Bswup/FullDemo/Client/wwwroot/service-worker.js
- src/Bswup/FullDemo/Client/wwwroot/service-worker.published.js
- src/Bup/Bit.Bup/Scripts/bit-bup.progress.ts
- src/Bup/Bit.Bup/Scripts/bit-bup.ts
- src/Butil/Bit.Butil/Scripts/butil.ts
- src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty.Client/BlazorEmpty.Client.csproj
- src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty/BlazorEmpty.csproj
- src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/wwwroot/service-worker.published.js
- src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props
- src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props
- src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages8.props
- src/Websites/Careers/src/Bit.Websites.Careers.Server/Bit.Websites.Careers.Server.csproj
- src/Websites/Careers/src/Bit.Websites.Careers.Shared/Bit.Websites.Careers.Shared.csproj
- src/Websites/Careers/src/Directory.Build.props
- src/Websites/Platform/src/Bit.Websites.Platform.Shared/Bit.Websites.Platform.Shared.csproj
- src/Websites/Platform/src/Directory.Build.props
- src/Websites/Sales/src/Bit.Websites.Sales.Server/Bit.Websites.Sales.Server.csproj
- src/Websites/Sales/src/Bit.Websites.Sales.Shared/Bit.Websites.Sales.Shared.csproj
- src/Websites/Sales/src/Directory.Build.props
🔇 Additional comments (16)
src/Websites/Platform/src/Bit.Websites.Platform.Server/Bit.Websites.Platform.Server.csproj (2)
13-16
: LGTM: Version update aligns with prerelease objectives
The version update from 9.1.0-pre-01 to 9.1.0-pre-02 for Bit.CodeAnalyzers is consistent with the PR's prerelease versioning goals.
17-20
: LGTM: Version update aligns with prerelease objectives
The version update from 9.1.0-pre-01 to 9.1.0-pre-02 for Bit.SourceGenerators is consistent with the PR's prerelease versioning goals.
Let's verify version consistency across the repository:
✅ Verification successful
Version consistency verified across the repository
The verification shows that:
- No instances of version 9.1.0-pre-01 were found in any project files
- All 17 project files consistently use version 9.1.0-pre-02 of Bit.SourceGenerators or Bit.CodeAnalyzers
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any inconsistent versions of Bit.CodeAnalyzers or Bit.SourceGenerators
# that might have been missed during the update
echo "Checking for any remaining pre-01 versions..."
rg -l "Bit\.(CodeAnalyzers|SourceGenerators).*9\.1\.0-pre-01" --type csproj
echo "Verifying all versions are updated to pre-02..."
rg -l "Bit\.(CodeAnalyzers|SourceGenerators).*9\.1\.0-pre-02" --type csproj
Length of output: 423
Script:
#!/bin/bash
# Let's try a different approach without relying on file type detection
# Search for PackageReference entries with Bit.SourceGenerators or Bit.CodeAnalyzers
echo "Checking for any remaining pre-01 versions..."
rg -l '<PackageReference Include="Bit\.(CodeAnalyzers|SourceGenerators)" Version="9\.1\.0-pre-01"'
echo "Verifying all versions are updated to pre-02..."
rg -l '<PackageReference Include="Bit\.(CodeAnalyzers|SourceGenerators)" Version="9\.1\.0-pre-02"'
Length of output: 1872
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj (1)
27-36
: LGTM! Version updates are consistent with prerelease v9.1.0-pre-02
The package reference updates align with the PR objectives for the prerelease version bump.
Let's verify version consistency across the solution:
✅ Verification successful
Version consistency verified across all Bit. package references*
All explicit version references for Bit.* packages are consistently set to "9.1.0-pre-02" across the solution. Some package references without explicit versions are template/conditional references (marked with msbuild-conditional comments) and are correctly left without version specifications.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that all Bit.* package references are consistently updated to version 9.1.0-pre-02
# Search for any Bit.* package references to ensure consistent versioning
rg --type xml '<PackageReference Include="Bit\.' -A 1
Length of output: 55
Script:
#!/bin/bash
# Let's try a different approach to find .csproj files and check package references
# First, find all .csproj files
fd -e csproj -x cat {} | grep -A 1 "PackageReference.*Bit\."
Length of output: 6442
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj (1)
32-38
: LGTM! Version updates align with prerelease objectives.
The package reference updates from 9.1.0-pre-01
to 9.1.0-pre-02
for both Bit.CodeAnalyzers
and Bit.SourceGenerators
are consistent with the PR's goal of preparing the v9.1.0-pre-02 release.
Let's verify version consistency across other project files:
✅ Verification successful
Version consistency verified across all Bit. package references*
All Bit.* package references in the solution consistently use version "9.1.0-pre-02", including:
- Bit.CodeAnalyzers
- Bit.SourceGenerators
- Bit.BlazorUI
- Bit.BlazorUI.Icons
- Bit.BlazorUI.Assets
- Bit.Bswup
- Bit.Butil
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that all Bit.* package references are consistently versioned
# Expected: All references should use version 9.1.0-pre-02
# Search for any Bit.* package references to ensure consistent versioning
rg --type csproj 'PackageReference Include="Bit\.' -A 1
Length of output: 88
Script:
#!/bin/bash
# Let's try a different approach to find .csproj files and their Bit.* package references
# First find all .csproj files, then grep for Bit.* package references
# Find all .csproj files and search for Bit.* package references
fd -e csproj -x grep -A 1 'PackageReference Include="Bit\.'
Length of output: 6138
src/Websites/Sales/src/Bit.Websites.Sales.Client/Bit.Websites.Sales.Client.csproj (2)
Line range hint 1-99
: LGTM! Project structure and configuration look solid
The project configuration is well-structured with:
- Appropriate framework targeting
- Well-organized build pipeline for JS/SCSS
- Proper resource handling
25-35
: Verify consistent version updates across the codebase
The package version updates to 9.1.0-pre-02
look good and align with the prerelease objectives. Let's verify that all Bit.* package references are updated consistently across the solution.
✅ Verification successful
All Bit. package versions are consistently updated to 9.1.0-pre-02*
The verification confirms that all Bit.* package references across the solution have been properly updated to version '9.1.0-pre-02'. There are no inconsistencies or mismatched versions found in any of the project files.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any inconsistent Bit.* package versions across all project files
# Find all .csproj files and check Bit.* package versions
fd -e csproj -x grep -A 1 -B 1 'Include="Bit\.' {} \; | grep 'Version='
Length of output: 4213
src/Websites/Careers/src/Bit.Websites.Careers.Client/Bit.Websites.Careers.Client.csproj (2)
25-35
: Verify version consistency across solution
The package version updates to 9.1.0-pre-02
look good and align with the prerelease objectives. Let's verify that all projects in the solution are updated consistently.
✅ Verification successful
Package versions are consistently updated across the solution
The search results confirm that all Bit.* packages have been updated to version 9.1.0-pre-02 across the entire solution. No references to the old version (9.1.0-pre-01) were found, and all projects are using the same version of the packages. The version update is complete and consistent.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any remaining references to the old version
# and ensure all projects are updated consistently
# Search for any remaining references to the old version
rg -l "9\.1\.0-pre-01" --type csproj
# List all current Bit.* package references to verify consistency
rg -A 1 "<PackageReference Include=\"Bit\." --type csproj
Length of output: 159
Script:
#!/bin/bash
# Search for any remaining references to the old version without file type filter
rg -l "9\.1\.0-pre-01"
# List all current Bit.* package references to verify consistency
rg -A 1 "<PackageReference Include=\"Bit\."
Length of output: 15108
Line range hint 20-21
: Verify consistent resource handling approach
The change to handle appsettings.json
as an EmbeddedResource
is appropriate for Blazor WASM apps. Let's verify this approach is consistent across similar projects.
✅ Verification successful
Consistent resource handling pattern confirmed across production websites
The verification shows that all production website projects in the codebase handle appsettings.json
consistently as an embedded resource:
Bit.Websites.Careers.Client
Bit.Websites.Sales.Client
Bit.Websites.Platform.Client
All use the same pattern:
<Content Remove="appsettings.json" />
<EmbeddedResource Include="appsettings.json" />
While demo and template projects don't explicitly specify the handling, this is expected as they serve different purposes. The change aligns with the established pattern across production website projects.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check how appsettings.json is handled in other Blazor WASM projects
# Find all Blazor WASM project files
fd -e csproj | while read -r proj; do
if grep -q "Sdk=\"Microsoft.NET.Sdk.BlazorWebAssembly\"" "$proj"; then
echo "Checking $proj:"
# Show how appsettings.json is handled in each project
grep -A 2 "appsettings.json" "$proj" || echo " No explicit appsettings.json handling found"
fi
done
Length of output: 12551
src/Websites/Platform/src/Bit.Websites.Platform.Client/Bit.Websites.Platform.Client.csproj (2)
25-36
: Package version updates look consistent.
The version updates align with the prerelease objective, updating all Bit.* packages to 9.1.0-pre-02 while maintaining Microsoft packages at their stable versions.
Let's verify version consistency across the solution:
✅ Verification successful
Package versions are consistently updated across the solution
All Bit.* packages across the solution are consistently using version 9.1.0-pre-02, with the exception of a few package references that don't specify versions (likely using centralized version management). No version inconsistencies were found that would cause compatibility issues.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any inconsistent package versions across the solution
# Search for any Bit.* package references that might have different versions
rg -U 'PackageReference Include="Bit\.' -A 1 '**/*.csproj' | grep -E 'Include=|Version='
Length of output: 142
Script:
#!/bin/bash
# Let's try with fd to find .csproj files first, then use ripgrep
fd -e csproj -x rg -U 'PackageReference Include="Bit\.' -A 1 {} | grep -E 'Include=|Version='
Length of output: 4398
Line range hint 18-22
: Verify configuration file handling changes.
The change of appsettings.json
from Content to EmbeddedResource could affect how configuration is loaded at runtime. Please ensure that:
- The application correctly loads configuration from embedded resources
- This change is intentional and aligned with the deployment strategy
Let's check for configuration loading code:
✅ Verification successful
Configuration loading is properly handled for embedded resources
The codebase shows consistent patterns of loading embedded appsettings.json files across multiple projects, including the Platform client project. The file Bit.Websites.Platform.Client/Extensions/IConfigurationBuilderExtensions.cs
specifically handles loading the embedded configuration:
builder.AddJsonStream(assembly.GetManifestResourceStream("Bit.Websites.Platform.Client.appsettings.json")!);
This confirms that:
- The application is designed to load configuration from embedded resources
- The change from Content to EmbeddedResource aligns with the project's configuration loading strategy
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check how configuration is loaded in the application
# Look for configuration loading code
ast-grep --pattern 'IConfiguration' -A 5
# Check for any appsettings.json loading patterns
rg -A 5 'GetManifestResourceStream.*appsettings\.json'
Length of output: 6292
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Bit.BlazorUI.Demo.Client.Core.csproj (1)
19-23
: Verify version consistency across the solution
The package version updates align with the PR objectives. Let's verify that all related packages are updated consistently across the solution.
✅ Verification successful
All Bit packages consistently updated to version 9.1.0-pre-02
The verification shows that all Bit packages across the solution have been properly updated to version 9.1.0-pre-02. No instances of the old version (9.1.0-pre-01) were found, and all package references maintain version consistency.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any inconsistent package versions across all project files
# Search for any Bit.* package references still using the old version
echo "Checking for any remaining 9.1.0-pre-01 versions:"
rg -l "Include=\"Bit\." | xargs rg "9\.1\.0-pre-01"
# List all current Bit.* package versions for verification
echo -e "\nCurrent Bit package versions:"
rg -A 1 "Include=\"Bit\." | rg "Version"
Length of output: 11687
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj (1)
88-91
: Version updates look consistent with prerelease objectives.
The package reference updates from 9.1.0-pre-01
to 9.1.0-pre-02
for both Bit.CodeAnalyzers
and Bit.SourceGenerators
align with the PR's prerelease versioning goals.
Let's verify version consistency across related packages in the solution:
Also applies to: 93-96
✅ Verification successful
Version updates are consistent across all Bit packages
The verification confirms that all Bit.* package references have been updated to version 9.1.0-pre-02
consistently across the entire solution. No instances of the old version 9.1.0-pre-01
were found, and all related packages (CodeAnalyzers, SourceGenerators, BlazorUI, etc.) are aligned to the same version.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for version consistency across Bit.* packages and potential conflicts
# Search for all Bit.* package references in .csproj files
echo "Checking Bit.* package versions across solution:"
rg -A 1 '<PackageReference Include="Bit\.' --type csproj
# Check for any remaining old versions
echo -e "\nChecking for any remaining 9.1.0-pre-01 versions:"
rg "9\.1\.0-pre-01" --type csproj
Length of output: 378
Script:
#!/bin/bash
# Search for all Bit.* package references in project files without file type restriction
echo "Checking Bit.* package versions across solution:"
rg -A 1 '<PackageReference Include="Bit\.'
# Check for any remaining old versions
echo -e "\nChecking for any remaining 9.1.0-pre-01 versions:"
rg "9\.1\.0-pre-01"
Length of output: 15327
src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor.cs (1)
41-41
: LGTM! Verify template version availability.
The version update aligns with the PR objectives for prerelease v-9.1.0-pre-02.
Let's verify the template version exists on NuGet:
src/Bswup/Bit.Bswup/Scripts/bit-bswup.sw.ts (2)
1-1
: Version update verified
Version string update matches the PR objectives for prerelease v-9.1.0-pre-02.
Also applies to: 1-1
Line range hint 275-283
: Verify passive first boot bypass behavior
The early return on passive first boot could affect the cache state. Ensure that subsequent non-passive boots properly initialize the cache.
✅ Verification successful
Let me gather more context about the passive first boot implementation to verify the cache behavior.
Based on the gathered information, I can now generate the final response:
Cache initialization is properly handled for passive first boot scenarios
The implementation correctly manages cache state:
- Cache creation is skipped only when both
isPassive
is true anddisablePassiveFirstBoot
is enabled - Non-passive boots always trigger cache initialization through
createAssetsCache()
- Cache state is properly maintained through
handleFetch
which falls back to network requests when cache is empty
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for cache initialization calls to verify proper handling
rg -A 5 "createAssetsCache|deleteOldCaches" --type ts
Length of output: 4084
Script:
#!/bin/bash
# Search for passive first boot related code and cache initialization
ast-grep --pattern 'if ($CONDITION) {
diag($MSG);
diagGroupEnd();
return;
}'
# Also search for isPassive checks
rg "isPassive|passive.*boot" --type ts -B 2 -A 2
Length of output: 2266
src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor (1)
170-171
: LGTM! Version update looks correct.
The version update from 9.1.0-pre-01
to 9.1.0-pre-02
is consistent across both the NuGet package link and the installation command.
Let's verify the NuGet package existence and version:
✅ Verification successful
Version update is consistent across the codebase
The version 9.1.0-pre-02
is consistently used throughout the codebase:
- In package references across multiple projects
- In template version comments
- In client-side script versions
- In the installation command and NuGet package link in the Templates03GettingStartedPage.razor file
While we couldn't directly verify the NuGet package existence through the API, the widespread consistent usage of this version across the entire codebase, including template files and package references, strongly indicates this is a valid version update.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that the NuGet package exists with the specified version
# Check if the package exists on NuGet
curl -s "https://api.nuget.org/v3/registration5-semver1/bit.boilerplate/index.json" | jq '.items[].items[] | select(.catalogEntry.version=="9.1.0-pre-02")'
Length of output: 155
Script:
#!/bin/bash
# Let's try a different approach to verify the version consistency across the codebase
# Search for any references to the version number in the codebase
rg -i "9\.1\.0-pre-0[12]" --type razor --type cs
# Also check if there are any other version references that might need updating
rg -i "bit\.boilerplate::\d+\.\d+\.\d+.*" --type razor --type cs
Length of output: 177
Script:
#!/bin/bash
# Let's try without file type filters since 'razor' is not recognized
# Search for any references to the version number in the codebase
rg -i "9\.1\.0-pre-0[12]"
# Also check if there are any other version references that might need updating
rg -i "bit\.boilerplate::\d+\.\d+\.\d+"
Length of output: 14114
closes #9319
Summary by CodeRabbit
Release Notes
New Features
9.1.0-pre-02
, enhancing overall performance and compatibility.Bug Fixes
Bit.CodeAnalyzers
,Bit.SourceGenerators
, and others across various projects.Documentation
These updates ensure a smoother development experience and improved functionality across the platform.