-
-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add HTTP API GET for module variables #3119
Conversation
Tested locally and the GET returns the value of module variables correctly |
For better User Experience (and any developers who have to work on your code later), I would suggest changing the naming you're using in the API and docs for It's very possible that a user could have multiple connections to the same module, each with different values for the same variable, so why not make things clearer that the API requires the connection label. For consistency it would be best if you adhere to the naming scheme already used within Companion. |
Changed all refrences to "module" to instead be "label" or "connection label" to make it more clear to users and better fit companion conventions
Looking good! |
Added unit tests for the module variable API call using the custom-variable get tests as a guideline
Thanks for the guidance! working on this issue has been a big confidence booster for me. Hopefully the first of many contributions. |
5a20f2c
to
8bdb917
Compare
8bdb917
to
27dfd4f
Compare
resolves #2830
added an API GET command to return value of variables from modules rather than just custom variables
This is my first experience with GIT/TypeScript and honestly I have no Idea if what I added works or how to go about testing. any guidance would be appreciated, I am enthusiastic but ignorant.