Fix domain/ranges of dbpedia property dataset

binh-vu · Mar 29, 2024 · 9f64836 · 9f64836
1 parent 66d63ea
commit 9f64836
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@
 
 - Add `entity_types` db
 
+### Fixed
+
+- Fix domain/ranges of dbpedia property dataset
+
 ## [7.1.0] (2024-03-28)
 
 ### Added

diff --git a/kgdata/dbpedia/datasets/properties.py b/kgdata/dbpedia/datasets/properties.py
@@ -66,11 +66,11 @@ def to_prop(resource: RDFResource, default_lang: str = "en") -> OntologyProperty
             description.lang = default_lang
             description.lang2value[default_lang] = ""
 
-    domains = None
+    domains = []
     if rdfs_domain in resource.props:
         domains = [str(term) for term in resource.props.get(rdfs_domain, [])]
 
-    ranges = None
+    ranges = []
     if (
         OWL.ObjectProperty in resource.props.get(rdf_type, [])
         and rdfs_range in resource.props

diff --git a/kgdata/models/ont_property.py b/kgdata/models/ont_property.py
@@ -16,6 +16,7 @@ class OntologyProperty:
     datatype: str
     instanceof: list[str]
     parents: list[str]
+    # do not include the property itself
     ancestors: dict[str, int]
     inverse_properties: list[str]
     related_properties: list[str]

diff --git a/scripts/build.sh b/scripts/build.sh
@@ -111,6 +111,7 @@ wikidata_dataset properties
 # dbpedia_db classes
 dbpedia_db properties
 # dbpedia_db entities
+# dbpedia_db entity_types
 # dbpedia_db entity_labels
 # dbpedia_db entity_metadata
 # dbpedia_db entity_redirections