Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LED Brightness Adjust #4105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpmreece
Copy link

@jpmreece jpmreece commented Jul 18, 2024

The Configurator has been modified to allow for a bightness adjust adjrange. This corresponds to the pull request on Betaflight " LED Dimmer #13776"
betaflight/betaflight#13776

This has been tested on Windows to program a SpeedyBeeF7V3

Added a brightness adjustment to allow an aux channel to change brightness.

Tested with SpeedyBeeF7V3. Needs Language Pack Added.
Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit 7c76818
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/6698cac6d76a36000869afd4
😎 Deploy Preview https://deploy-preview-4105.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nerdCopter
Copy link
Member

nerdCopter commented Aug 6, 2024

Tested UI, but not functions.
image

edit:

# diff

# adjrange
adjrange 0 0 0 1700 2100 31 10 0 0
adjrange 1 0 4 1275 1675 30 11 0 0

@jpmreece
Copy link
Author

jpmreece commented Aug 6, 2024

Tested UI, but not functions.

Does this mean that I need to do further testing? It should pass an adjrange through to the device.

@nerdCopter
Copy link
Member

Does this mean that I need to do further testing? It should pass an adjrange through to the device.

It only means i did not fully test and maybe do not know how to fully test and further do not have the hardware to fully test.
I put the screenshot so at least other's know where to test.

@jpmreece
Copy link
Author

jpmreece commented Aug 6, 2024

Does this mean that I need to do further testing? It should pass an adjrange through to the device.

It only means i did not fully test and maybe do not know how to fully test and further do not have the hardware to fully test. I put the screenshot so at least other's know where to test.

I tested (before testing with a drone) that saving added the appropriate adjrange value of 31. This can be checked in the cli and should correspond with the enum in rc_adjustments.h

typedef enum { ADJUSTMENT_NONE = 0, ADJUSTMENT_RC_RATE, ADJUSTMENT_RC_EXPO, ADJUSTMENT_THROTTLE_EXPO, ADJUSTMENT_PITCH_ROLL_RATE, ADJUSTMENT_YAW_RATE, ADJUSTMENT_PITCH_ROLL_P, ADJUSTMENT_PITCH_ROLL_I, ADJUSTMENT_PITCH_ROLL_D, ADJUSTMENT_YAW_P, ADJUSTMENT_YAW_I, ADJUSTMENT_YAW_D, ADJUSTMENT_RATE_PROFILE, ADJUSTMENT_PITCH_RATE, ADJUSTMENT_ROLL_RATE, ADJUSTMENT_PITCH_P, ADJUSTMENT_PITCH_I, ADJUSTMENT_PITCH_D, ADJUSTMENT_ROLL_P, ADJUSTMENT_ROLL_I, ADJUSTMENT_ROLL_D, ADJUSTMENT_RC_RATE_YAW, ADJUSTMENT_PITCH_ROLL_F, ADJUSTMENT_FEEDFORWARD_TRANSITION, ADJUSTMENT_HORIZON_STRENGTH, ADJUSTMENT_ROLL_RC_RATE, ADJUSTMENT_PITCH_RC_RATE, ADJUSTMENT_ROLL_RC_EXPO, ADJUSTMENT_PITCH_RC_EXPO, ADJUSTMENT_PID_AUDIO, ADJUSTMENT_PITCH_F, ADJUSTMENT_ROLL_F, ADJUSTMENT_YAW_F, ADJUSTMENT_OSD_PROFILE, ADJUSTMENT_LED_PROFILE, ADJUSTMENT_LED_DIMMER, ADJUSTMENT_FUNCTION_COUNT } adjustmentFunction_e;

Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haslinghuis haslinghuis added this to the 11.0 milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants