Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration testing step in CI #46

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Add integration testing step in CI #46

merged 1 commit into from
Oct 20, 2024

Conversation

berniegp
Copy link
Owner

@berniegp berniegp commented Oct 16, 2024

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless necessary)
  • no

Related issue numbers:

Description

  • The build job now outputs an npm package tarball as build artifact
  • Moves the multi-platform GitHub action CI tests to a new packageTest job.
  • The new job checks
    • that the built package tarball can be installed and used in a minimal integration test
    • that the above works in both commonjs and module package types

This change will allow the build toolchain to use newer tool versions that are not available in all supported node versions of this package. The previous approach built the project on all supported node versions which adds unneeded extra complexity for real uses of this package.

@berniegp berniegp marked this pull request as ready for review October 20, 2024 10:11
@berniegp berniegp merged commit 6d588a7 into main Oct 20, 2024
16 checks passed
@berniegp berniegp deleted the test-gh-actions branch October 20, 2024 10:12
@berniegp berniegp changed the title Test upload and download workflow Add integration testing step in CI Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant