Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

#171 VM起動後にharoが起動していない #218

Merged
merged 2 commits into from
Nov 4, 2020

Conversation

NaoY-2501
Copy link
Contributor

@NaoY-2501 NaoY-2501 commented Nov 4, 2020

チケットURL

このレビューで確認してほしい点

  • haroのserviceのenabledが有効になっていること

レビューチェックリスト

  • C2 体を表す名前の公理:あらかじめ決められている以外の汎用的な名前のモジュールを作らない
  • C3 汎用名のモジュール内に長々と具体的処理を書かない
  • C4 単純な処理の長さで分割しない
  • C5 引数の数を減らす
  • C6 パッケージ間で共通した定数を作らない
  • C7 継承の利用を最小限にする
  • C8 親クラスのテストを子クラスでも実行すること
  • C9 オーバーライドを減らす
  • C10 継承やオーバーライドを明示する

@NaoY-2501 NaoY-2501 self-assigned this Nov 4, 2020
@NaoY-2501 NaoY-2501 changed the title wip. #171 VM起動後にharoが起動していない #171 VM起動後にharoが起動していない Nov 4, 2020
@NaoY-2501 NaoY-2501 requested review from a team and altnight and removed request for a team and altnight November 4, 2020 06:51
@wanshot wanshot requested review from a team and takanory and removed request for a team November 4, 2020 06:58
Copy link
Contributor

@altnight altnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@takanory takanory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

はい

Copy link
Member

@takanory takanory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ちょっとーーー

@NaoY-2501
Copy link
Contributor Author

@altnight masterマージします

@NaoY-2501 NaoY-2501 merged commit 3b6bf05 into master Nov 4, 2020
@NaoY-2501 NaoY-2501 deleted the t171-haro-service-enable-on-reboot branch November 4, 2020 08:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants