-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable inline attachments for mailgun. #551
base: main
Are you sure you want to change the base?
Conversation
At the time of writing, mailgun sets the content-id of the attachment to the supplied filename. I have an open ticket with them to see if there is a way to override this. If not, it's not 100% ideal, but it is a working solution. |
Official stance from mailgun is that they don't currently support specifying |
Thanks for opening this PR @astjohn. Do you have any links to Mailgun documentation that I could reference to help me review this PR? |
It's been a while. Updating our own branch and coming back around to this. Here's the mailgun docs: If you'd like to verify what I went through with Mailgun, feel free to email them. As far as I know, their stance hasn't changed on the matter. |
@astjohn, thanks so much for looping back and rebasing the PR to be up to date! Would you mind adding a test for the MailgunAdapter so the changes are tested? I think once we have that, this is good to go. 👍 |
This pull request has been automatically marked as "stale:discard". If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated!. |
This PR enables inline attachments for mailgun.